fix: only apply completiongradeitemnumber modification to elements co…

…mpleted via a grade
ProjektAdLer · Dec 3, 2024 · feb95ba · feb95ba
1 parent 6d0255e
commit feb95ba
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/classes/local/upgrade/upgrade_3_2_0_to_4_0_0_completionlib.php b/classes/local/upgrade/upgrade_3_2_0_to_4_0_0_completionlib.php
@@ -134,8 +134,12 @@ public function set_completion_to_auto(stdClass $cm_info, bool $view): void {
         $this->moodle_core_repository->update_course_module_record($cm_info->id, [
             'completion' => 2,
             'completionpassgrade' => $view ? 0 : 1,
-            'completionview' => $view ? 1 : 0,
-            'completiongradeitemnumber' => 0
+            'completionview' => $view ? 1 : 0
         ]);
+        if (!$view) {
+            $this->moodle_core_repository->update_course_module_record($cm_info->id, [
+                'completiongradeitemnumber' => 0
+            ]);
+        }
     }
 }