fix wrong error handling

ProjektAdLer · Oct 9, 2024 · c0c867c · c0c867c
1 parent e60bf24
commit c0c867c
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/classes/local/upgrade/upgrade_3_2_0_to_4_0_0_completionlib.php b/classes/local/upgrade/upgrade_3_2_0_to_4_0_0_completionlib.php
@@ -97,14 +97,14 @@ public function upgrade_modules(): void {
      * @throws dml_exception
      */
     public function upgrade_h5p_module(stdClass $cm_info): void {
-        $grade_item = $this->moodle_core_repository->get_grade_item('h5pactivity', $cm_info->instance);
-        if ($grade_item) {
+        try {
+            $grade_item = $this->moodle_core_repository->get_grade_item('h5pactivity', $cm_info->instance);
             $this->logger->info('Setting completion for h5p cm ' . $cm_info->id . ' to "passing grade"');
             $this->set_completion_to_auto($cm_info, false);
             $this->moodle_core_repository->update_grade_item_record($grade_item->id, [
                 'gradepass' => $grade_item->grademax
             ]);
-        } else {
+        } catch (dml_exception $e) {
             $this->logger->error('No grade item found for h5p cm ' . $cm_info->id);
         }
     }