Skip to content

Commit

Permalink
pipeline update
Browse files Browse the repository at this point in the history
- phpunit workaround not required anymore as either moodle-plugin-ci bug was fixed or explicitly enabling pcov (instead of default phpdbg) for coverage avoids that bug (moodlehq/moodle-plugin-ci#204)
- update (unused) code checker to match new v4 of moodle-plugin-ci
  • Loading branch information
Glutamat42 committed Feb 15, 2024
1 parent 11bc42a commit 93442c1
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions .github/workflows/moodle-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ jobs:
# Coding style for this plugin differs from moodle's coding style in some points
# - name: Moodle Code Checker
# if: ${{ always() }}
# run: moodle-plugin-ci codechecker --max-warnings 0
# run: moodle-plugin-ci phpcs --max-warnings 0

- name: Moodle PHPDoc Checker
continue-on-error: true
Expand Down Expand Up @@ -132,11 +132,7 @@ jobs:
- name: PHPUnit tests
if: ${{ always() }}
run: |
cd moodle
php -d pcov.enabled=1 -d pcov.directory=. vendor/bin/phpunit --coverage-text --configuration local/adler --testdox --coverage-clover local/adler/coverage.xml
# restore tests are randomly causing segfaults when run with moodle-plugin-ci, but run totally fine when run with phpunit directly
# https://github.com/moodlehq/moodle-plugin-ci/issues/204
# moodle-plugin-ci phpunit --fail-on-warning --coverage-clover --coverage-text -vvv
moodle-plugin-ci phpunit --fail-on-warning --coverage-clover --testdox --coverage-pcov --coverage-text -vvv
- name: Coveralls upload
continue-on-error: true
Expand Down

0 comments on commit 93442c1

Please sign in to comment.