-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookbook Revisions #23
Conversation
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
…ate README for the whole cookbook accordingly (#24) * Populate all the notebooks of 01-foundations. Also update README for teh whole cookbook accordingly * Update README.md
* Populated the Intro-to-UXarray Notebooks * small revisions * revisions (2) --------- Co-authored-by: Philip Chmielowiec <[email protected]>
Now that we have all the never folders, we can and should remove the older dirs starting with "_01", "_02", and "_03", right? |
Yes we can remove them now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks great! I really enjoyed reading them all under the Plotting with UXarray and the Recipes. Just a few things to note:
- There were only a few typos to correct that I've already fixed. No action there for you.
- The content of MPAS Atmosphere and MPAS Ocean feels like atmosphere should come before ocean (e.g. there are more MPAS insights delivered in the atmosphere one, and it feels like a more comprehensive recipe)
- MPAS ocean has no text at all once the plotting code starts. Is it intentional? I don't have big issues with that since the plotting is pretty self-explanatory (though it may feel so to us only), but it feels a bit awkward compared to the rest of the cookbook.
Thanks for correcting these!
That's a good idea.
Yeah, I couldn't come up with much when I was writing it. I will at least populate some small markdown describing the plots. |
For the |
I've also populated the E3SM recipie If you have a chance @rytam2, may you skim over it and make sure I didn't incorrectly list anything. This is a slightly modified version of the user guide you put together. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave this a second review now, and all look good to me except that the Comparison to Xarray does not show up in the preview though its notebook seems populated.
Oops. I'll fix that. |
Overview