Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookbook Revisions #23

Merged
merged 55 commits into from
Jan 9, 2025
Merged

Cookbook Revisions #23

merged 55 commits into from
Jan 9, 2025

Conversation

philipc2
Copy link
Collaborator

@philipc2 philipc2 commented Nov 4, 2024

Overview

  • Cookbook revisions for the 2025 AMS Short Course

Copy link

github-actions bot commented Nov 4, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 9b0c4c3
✅ Deployment Preview URL: https://ProjectPythia.github.io/unstructured-grid-viz-cookbook/_preview/23

philipc2 and others added 28 commits November 4, 2024 14:09
…ate README for the whole cookbook accordingly (#24)

* Populate all the notebooks of 01-foundations. Also update README for teh whole cookbook accordingly

* Update README.md
* Populated the Intro-to-UXarray Notebooks

* small revisions

* revisions (2)

---------

Co-authored-by: Philip Chmielowiec <[email protected]>
@erogluorhan
Copy link
Member

Now that we have all the never folders, we can and should remove the older dirs starting with "_01", "_02", and "_03", right?

@philipc2
Copy link
Collaborator Author

philipc2 commented Jan 9, 2025

Now that we have all the never folders, we can and should remove the older dirs starting with "_01", "_02", and "_03", right?

Yes we can remove them now.

Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great! I really enjoyed reading them all under the Plotting with UXarray and the Recipes. Just a few things to note:

  • There were only a few typos to correct that I've already fixed. No action there for you.
  • The content of MPAS Atmosphere and MPAS Ocean feels like atmosphere should come before ocean (e.g. there are more MPAS insights delivered in the atmosphere one, and it feels like a more comprehensive recipe)
  • MPAS ocean has no text at all once the plotting code starts. Is it intentional? I don't have big issues with that since the plotting is pretty self-explanatory (though it may feel so to us only), but it feels a bit awkward compared to the rest of the cookbook.

@philipc2
Copy link
Collaborator Author

philipc2 commented Jan 9, 2025

There were only a few typos to correct that I've already fixed. No action there for you.

Thanks for correcting these!

The content of MPAS Atmosphere and MPAS Ocean feels like atmosphere should come before ocean (e.g. there are more MPAS insights delivered in the atmosphere one, and it feels like a more comprehensive recipe)

That's a good idea.

MPAS ocean has no text at all once the plotting code starts. Is it intentional? I don't have big issues with that since the plotting is pretty self-explanatory (though it may feel so to us only), but it feels a bit awkward compared to the rest of the cookbook.

Yeah, I couldn't come up with much when I was writing it. I will at least populate some small markdown describing the plots.

@philipc2
Copy link
Collaborator Author

philipc2 commented Jan 9, 2025

@erogluorhan

For the mpas-ocean visual, I've added markdown that discusses the choice for using a vector-polygon approach for the subset (since it is small and only contaisn 164) elements and the choice for using a raster-polygon for the global grid. I think that additional info should tell a good story.

@philipc2
Copy link
Collaborator Author

philipc2 commented Jan 9, 2025

I've also populated the E3SM recipie

If you have a chance @rytam2, may you skim over it and make sure I didn't incorrectly list anything. This is a slightly modified version of the user guide you put together.

@philipc2 philipc2 self-assigned this Jan 9, 2025
@erogluorhan erogluorhan self-requested a review January 9, 2025 16:29
Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave this a second review now, and all look good to me except that the Comparison to Xarray does not show up in the preview though its notebook seems populated.

@philipc2
Copy link
Collaborator Author

philipc2 commented Jan 9, 2025

I gave this a second review now, and all look good to me except that the Comparison to Xarray does not show up in the preview though its notebook seems populated.

Oops. I'll fix that.

@philipc2 philipc2 merged commit 495f591 into main Jan 9, 2025
2 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants