Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish the NumPy content #240

Merged
merged 6 commits into from
Mar 31, 2022
Merged

Conversation

brian-rose
Copy link
Member

This PR partially addresses #231 by removing "Under construction" from the NumPy landing page. Also adds the Numpy logo to that page, and fixes some small styling issues throughout the NumPy notebooks (e.g. consistent capitalization of the words "NumPy", "Maplotlib", "Xarray", etc.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented Mar 1, 2022

This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below.

🔍 Git commit SHA: 7a30ddb
✅ Deployment Preview URL: https://624616028b723a1ffe873a0a--pythia-foundations.netlify.app

@brian-rose brian-rose marked this pull request as ready for review March 1, 2022 15:54
@brian-rose brian-rose requested a review from a team as a code owner March 1, 2022 15:54
@brian-rose brian-rose requested review from dopplershift and anissa111 and removed request for a team March 1, 2022 15:54
@jukent jukent added the content Content related issue label Mar 2, 2022
@brian-rose
Copy link
Member Author

Hi @dopplershift and @anissa111, would you be able to take a look at this PR sometime soon, or should I reassign to different reviewers?

@kmpaul kmpaul self-requested a review March 31, 2022 17:32
@mgrover1 mgrover1 self-requested a review March 31, 2022 17:32
Copy link
Contributor

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - thanks for making all those capitalization changes and updating the NumPy landing page @brian-rose

Copy link
Contributor

@kmpaul kmpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe with the changes I pushed up (just typo fixes and some grammar), this looks good to me.

@brian-rose brian-rose merged commit 4717859 into ProjectPythia:main Mar 31, 2022
@brian-rose
Copy link
Member Author

Great! Thanks @mgrover1 and @kmpaul for the reviews and the fixes!

@brian-rose brian-rose deleted the numpy-polish branch March 31, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants