RERUM Service Adapter for Online Annotations #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* functional TinyThings adapter * functional TinyThings adapter * documentation * Tighten it up * Some notes from playing with this as a TPEN 2.8 viewer/annotator * ready * meh use the functional manifest * meh use the functional manifest * make happy lint * splice() * change delete(). undiff package.json * Let all() have a better chance to only match on the one AnnotationPage it is looking for instead of finding many. * remove null returns. undefined is the natural state. * oops gaurd the get(annoId) * touch of cleanup * also scrub response in helper functions if we are scrubbing them in the main ones * what we think update means * track 'creator' in helper functions as well * ah maybe the attempt to remember this.knownAnnoPage is no good * no this.knownAnnoPage * no this.knownAnnoPage * ughh messy now...co-op will help * ok back to sanity with what we learned * not. fair. id. * all functional now * resolve lint workarounds * Ready for Patrick * suggestions * lint avoidance * cleanup linty loop * fix from note (return []) * codebeat complaints * demo * one last lint thing * touch ups] * functional update() * prepareForRerum * babel accommodation * redundant default * polishing * polishing and happy lint * polishing and happy lint * polishing and happy lint * ready * undiff * ready * cleanup * co-op --------- Co-authored-by: cubap <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a RERUM adapter to Mirador for publishing and consuming annotations.