docs/issue 144 best practices and recommendations for import maps and referencing node modules #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for super-tapioca-5987ce ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thescientist13
changed the title
40 tasks
thescientist13
commented
Dec 19, 2024
src/pages/docs/resources/styles.md
Outdated
| @import "../../node_modules/open-props/src/props.fonts.css"; | ||
| @import "../../node_modules/open-props/src/props.shadows.css"; | ||
| @import "../../node_modules/open-props/src/props.sizes.css"; | ||
| @import "../../]node_modules/open-props/borders.min.css"; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
thescientist13
commented
Jan 10, 2025
| Some known issues / examples observed so far include: | ||
|
|
||
| - `ERR_MODULE_NOT_FOUND` - Observed with packages like [**@types/trusted-types**](https://github.com/DefinitelyTyped/DefinitelyTyped), which has an [empty string](https://unpkg.com/browse/@types/[email protected]/package.json) for the **main** field, and [**font-awesome**](https://fontawesome.com/), which has [no entry point](https://unpkg.com/browse/[email protected]/package.json) at all, at least as of `v4.x`. | ||
| - `ERR_PACKAGE_PATH_NOT_EXPORTED` - Encountered with the [**geist-font** package](https://vercel.com/font), which has [no default export](https://github.com/vercel/geist-font/issues/150) in its exports map |
There was a problem hiding this comment.
found some more examples
and what about things that are only types?
https://www.npmjs.com/package/type-fest
thescientist13
commented
Jan 17, 2025
|
|
||
| Some known issues / examples observed so far include: | ||
|
|
||
| - `ERR_MODULE_NOT_FOUND` - Observed with packages like [**@types/trusted-types**](https://github.com/DefinitelyTyped/DefinitelyTyped), which has an [empty string](https://unpkg.com/browse/@types/[email protected]/package.json) for the **main** field, and [**font-awesome**](https://fontawesome.com/), which has [no entry point](https://unpkg.com/browse/[email protected]/package.json) at all, at least as of `v4.x`. |
There was a problem hiding this comment.
found another example with type-fest
Merged
6 tasks
thescientist13
force-pushed
the
docs/issue-144-best-practices-and-recommendations-for-import-maps-and-referencing-node-modules
branch
from
5056c1a to
a4c545c
Compare
thescientist13
deleted the
docs/issue-144-best-practices-and-recommendations-for-import-maps-and-referencing-node-modules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #144
Summary of Changes
/node_modulesbased pathsTODO
ERR_MODULE_NOT_FOUNDare related to typescript files. Any way we can see those project's have a package.json with just atypesfield (and none of our supported conditions) and suppress the error, since we can assume it's just a types file?