Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix hiding of attribute described in markdown. #139

Merged
merged 11 commits into from
Nov 18, 2024
Merged

Attempt to fix hiding of attribute described in markdown. #139

Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6a87a35
Attempt to fix hiding of attribute described in markdown.
brettle Nov 17, 2024
ee39174
Revert to normal double quotes.
brettle Nov 17, 2024
49920ec
Try removing remark-github plugin.
brettle Nov 17, 2024
ed7ed34
Try removing rehype-prism plugin instead.
brettle Nov 17, 2024
1c6f6b2
Try removing rehype-slug and rehype-autolink-headings instead.
brettle Nov 17, 2024
506f294
Try removing all markdown plugins.
brettle Nov 17, 2024
cce0caf
Restore all plugins because they were not the cause.
brettle Nov 17, 2024
f006fd4
Eliminate quotes to see if they are the problem.
brettle Nov 17, 2024
78b8cc2
Merge branch 'main' into patch-6
brettle Nov 17, 2024
c3c20c2
Use single quotes.
brettle Nov 18, 2024
faba07d
Merge branch 'main' into patch-6
brettle Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/guides/getting-started/going-further.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Now if we look in the HTML output for any of our pages, we will see pre-rendered
</app-footer>
```

We can go one step further and instruct Greenwood to strip out the `<script>` tags for these components by adding the `data-gwd-opt="static"` attribute to them, since we have no need for any interactivity on these components.
We can go one step further and instruct Greenwood to strip out the `<script>` tags for these components by adding the `data-gwd-opt=static` attribute to them, since we have no need for any interactivity on these components.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like single quotes works at least, so we can just roll with that for now


```html
<script type="module" src="../components/footer/footer.js" data-gwd-opt="static"></script>
Expand Down