-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS Modules #11
CSS Modules #11
Conversation
✅ Deploy Preview for super-tapioca-5987ce ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
plugin-css-modules.js
Outdated
@@ -0,0 +1,139 @@ | |||
/* | |||
* | |||
* Manages web standard resource related operations for CSS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol, just a little copy 🍝 here 😅
plugin-css-modules.js
Outdated
contents: scopedCssContents | ||
}) | ||
// sheets.push(cssContents); | ||
} else if(node.source.value.endsWith('.js')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO - how to handle other file types / extensions? Do we even need to check, can was assume something should already be there to handle it?
a71ef1f
to
c8c5786
Compare
329ff4b
to
5002f0b
Compare
Related Issue
Final part of #7, to compliment our usage of #38
Summary of Changes
TODOs
prerender
/ static optimization supportimport
lines out of JavaScript, aka zero "runtime" (only at build time?)break
fix? - leverageSec-Fetch-Dest
header for better filtering within Greenwood resource plugins greenwood#1222Questions / Discussions
prerendering
because things run in a Worker Thread? 🤔 )Could use a better data structure for sheets, like aMap
orSet
?