detect, use and respond with document or fragement html #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
deleted the
enhancment/issue-30-standardize-render-api-respone-html
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #30
Summary of Changes
Observations
So I see cheerio has to do something like this by accounting for
<head>,<html>, and<body>tags, and hopefully this works because parse will automatically do this if usingparse, andparseFragmentwill actually strip them out if they are. 😵Also another vote for #14 because JSDOM will also infer these tags if they are there or not
which is why I had to hack in this test because the specs were passing whether I was using
parseorparseFragment. If we can bypass all that and just test HTML <> HTML directly. 🤞Maybe we should allow an
isDocumentoption, to avoid the confusion and let user's override / specify themselves? But it would only be for top level, in theory, so if it is present, only render the top asparseorparseFragment, and the rest asparseFragment.