Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/issue 879 static export ssr routes #921

Merged
merged 5 commits into from
Jul 1, 2022
Merged

Feature/issue 879 static export ssr routes #921

merged 5 commits into from
Jul 1, 2022

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Mar 26, 2022 •
edited
Loading

Related Issue

resolves #879

Summary of Changes

  1. Add feature for being able to static export a SSR route
  2. Added documentation and specs

TODO

  1. Wait for prerender work to get merged and rebase
  2. Add support for greenwood.config.js prerender: false with per page opt-in for static exporting for mix and matching, as opposed to all or nothing
  3. SSR still outputs HTML, due to avoid Rollup double bundling for pre-bundled static assets for server routes #883 , may not be able to clear up no static writing TODO

Deferring the above two to #951

@thescientist13 thescientist13 added documentation Greenwood specific docs CLI SSR feature New feature or request labels Mar 26, 2022
@thescientist13 thescientist13 self-assigned this Mar 26, 2022
@thescientist13 thescientist13 mentioned this pull request Jun 18, 2022
Merged
18 tasks
@thescientist13 thescientist13 force-pushed the feature/issue-879-static-export-ssr-routes branch from 6d30d12 to 44d636a Compare June 29, 2022 00:45
@thescientist13 thescientist13 mentioned this pull request Jun 29, 2022
Closed
@thescientist13 thescientist13 marked this pull request as ready for review June 29, 2022 01:23
@thescientist13 thescientist13 force-pushed the feature/issue-879-static-export-ssr-routes branch from 44d636a to eb269d4 Compare July 1, 2022 00:27
@thescientist13 thescientist13 changed the base branch from master to release/0.26.0 July 1, 2022 01:07
@thescientist13 thescientist13 force-pushed the feature/issue-879-static-export-ssr-routes branch from eb269d4 to a4d5c2c Compare July 1, 2022 02:11
@thescientist13 thescientist13 merged commit ec7e1c9 into release/0.26.0 Jul 1, 2022
@thescientist13 thescientist13 deleted the feature/issue-879-static-export-ssr-routes branch July 1, 2022 02:41
thescientist13 added a commit that referenced this pull request Jul 27, 2022
@thescientist13
Feature/issue 879 static export ssr routes (#921)
782fb85 
* working version of SSR static export

* update comment

* document static SSR export

* refactor and TODOs

* break pass by reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thescientist13 thescientist13

Labels
CLI documentation Greenwood specific docs feature New feature or request SSR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should have the ability to statically export server rendered routes as just HTML
1 participant
@thescientist13