Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor to use octokit to get repos instead of node-fetch #886

Closed
wants to merge 1 commit into from

Conversation

thescientist13
Copy link
Member

Related Issue

N / A

Have been seeing the init tests fail intermittently a number of times now and not sure why. I thought it was a rate limit issue (60 / hr) but even if no tests have been run for a couple days, it will still fail right away. 😵‍💫

Summary of Changes

  1. Swap out node-fetch with octokit SDK

Not sure if this will actually fix it per se, but will run this PR a few times through GitHub actions and see if it helps

@thescientist13 thescientist13 added chore unit testing, maintenance, etc Init labels Feb 11, 2022
@thescientist13
Copy link
Member Author

lol, first run failed due to #876 😅 😭

@thescientist13 thescientist13 force-pushed the chore/fix-init-intermittent-ci-errors branch from 93316c3 to 34651b6 Compare February 12, 2022 16:17
@thescientist13 thescientist13 force-pushed the chore/fix-init-intermittent-ci-errors branch from 34651b6 to a33e34b Compare February 19, 2022 16:30
@thescientist13 thescientist13 marked this pull request as ready for review February 19, 2022 16:30
@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) v0.24.0 and removed chore unit testing, maintenance, etc labels Feb 19, 2022
Copy link
Member

@hutchgrant hutchgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thescientist13
Copy link
Member Author

Interestingly enough, this issue hasn't come up in our GitHub Actions at all recently. 🤔 🤷‍♂️

@thescientist13
Copy link
Member Author

So this issue basically hasn't reproduced itself in close to a year now, so I think we can close this one and leave it as is. As part of #957 , we can migrate to fetch though 👍

@thescientist13 thescientist13 deleted the chore/fix-init-intermittent-ci-errors branch December 18, 2022 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve something existing (e.g. no docs, new APIs, etc) Init
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants