[DO NOT MERGE] Rfc/issue 354 strict mode inline script poc #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
the
RFC
thescientist13
changed the base branch from
master
to
rfc/issue-354-spa-and-ssg-modes
21 tasks
thescientist13
force-pushed
the
rfc/issue-354-spa-and-ssg-modes
branch
from
12e83c6 to
cece625
Compare
thescientist13
force-pushed
the
rfc/issue-354-strict-mode-inline-script-poc
branch
from
1bfd51a to
a11e092
Compare
thescientist13
changed the base branch from
rfc/issue-354-spa-and-ssg-modes
to
master
thescientist13
commented
Aug 6, 2020
There was a problem hiding this comment.
Code wise I think this is all ready, just need to make the follow up issues. Also updated the static POC branch PR.
EDIT: oops, wrong PR.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
related to #354 and as a demo / POC built on top of #396
Summary of Changes
By writing inline JavaScript, even in strict mode we can still run JavaScript 👀 😎
