Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/issue 1048 handle URL encoded Netlify form params #1148

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Aug 27, 2023

Related Issue

relates to #1048

Upon testing ProjectEvergreen/greenwood-demo-adapter-netlify#9, saw that Netlify was providing form data as key=value for body
Screen Shot 2023-08-26 at 8 48 21 PM
Screen Shot 2023-08-26 at 8 48 32 PM

Summary of Changes

  1. Match how Netlify provides application/x-www-form-urlencoded params
  2. Updated test case accordingly

@thescientist13 thescientist13 added this to the 1.0 milestone Aug 27, 2023
@thescientist13 thescientist13 changed the base branch from master to release/0.29.0 August 27, 2023 01:11
@thescientist13 thescientist13 changed the title Bug/issue 1048 handle url encoded netlify form params bug/issue 1048 handle URL encoded Netlify form params Aug 27, 2023
@thescientist13 thescientist13 force-pushed the bug/issue-1048-handle-url-encoded-netlify-form-params branch from a81b92b to 42d61be Compare September 1, 2023 12:36
@thescientist13 thescientist13 mentioned this pull request Sep 1, 2023
25 tasks
@thescientist13 thescientist13 merged commit 8ccb7df into release/0.29.0 Sep 1, 2023
@thescientist13 thescientist13 deleted the bug/issue-1048-handle-url-encoded-netlify-form-params branch September 1, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

handle merging additional Request / Response instance properties
1 participant