Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix up for migrations #1010

Merged
merged 1 commit into from
Jul 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

namespace Monai.Deploy.WorkflowManager.Common.Contracts.Migrations
{
public class M005_Payload_seriesUid : DocumentMigration<Payload>

Check warning on line 22 in src/WorkflowManager/Contracts/Migrations/M005_Payload_seriesUid.cs

View workflow job for this annotation

GitHub Actions / sonarscanner

Rename class 'M005_Payload_seriesUid' to match pascal case naming rules, consider using 'M005PayloadseriesUid'. (https://rules.sonarsource.com/csharp/RSPEC-101)
{
public M005_Payload_seriesUid() : base("1.0.5") { }

Expand All @@ -27,10 +27,10 @@
{
try
{
document.Add("SeriesInstanceUid", BsonNull.Create(null).ToJson(), true);
document.Add("SeriesInstanceUid", new BsonString(""), true);
}
catch

Check warning on line 32 in src/WorkflowManager/Contracts/Migrations/M005_Payload_seriesUid.cs

View workflow job for this annotation

GitHub Actions / sonarscanner

Handle the exception or explain in a comment why it can be ignored. (https://rules.sonarsource.com/csharp/RSPEC-2486)
{

Check warning on line 33 in src/WorkflowManager/Contracts/Migrations/M005_Payload_seriesUid.cs

View workflow job for this annotation

GitHub Actions / sonarscanner

Either remove or fill this block of code. (https://rules.sonarsource.com/csharp/RSPEC-108)
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

namespace Monai.Deploy.WorkflowManager.Common.Contracts.Migrations
{
public class M006_Payload_triggeredWorkflows : DocumentMigration<Payload>

Check warning on line 22 in src/WorkflowManager/Contracts/Migrations/M006_Payload_triggeredWorkflows.cs

View workflow job for this annotation

GitHub Actions / sonarscanner

Rename class 'M006_Payload_triggeredWorkflows' to match pascal case naming rules, consider using 'M006PayloadtriggeredWorkflows'. (https://rules.sonarsource.com/csharp/RSPEC-101)
{
public M006_Payload_triggeredWorkflows() : base("1.0.6") { }

Expand All @@ -27,10 +27,10 @@
{
try
{
document.Add("TriggeredWorkflowNames", BsonNull.Create(null).ToJson(), true);
document.Add("TriggeredWorkflowNames", new BsonArray());
}
catch

Check warning on line 32 in src/WorkflowManager/Contracts/Migrations/M006_Payload_triggeredWorkflows.cs

View workflow job for this annotation

GitHub Actions / sonarscanner

Handle the exception or explain in a comment why it can be ignored. (https://rules.sonarsource.com/csharp/RSPEC-2486)
{

Check warning on line 33 in src/WorkflowManager/Contracts/Migrations/M006_Payload_triggeredWorkflows.cs

View workflow job for this annotation

GitHub Actions / sonarscanner

Either remove or fill this block of code. (https://rules.sonarsource.com/csharp/RSPEC-108)
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/WorkflowManager/Contracts/Models/Payload.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

namespace Monai.Deploy.WorkflowManager.Common.Contracts.Models
{
[CollectionLocation("Payloads"), RuntimeVersion("1.0.7"), StartUpVersion("1.0.7")]
[CollectionLocation("Payloads"), RuntimeVersion("1.0.7")]
public class Payload : IDocument
{
[JsonConverter(typeof(DocumentVersionConvert)), BsonSerializer(typeof(DocumentVersionConverBson))]
Expand Down
2 changes: 1 addition & 1 deletion src/WorkflowManager/Contracts/Models/WorkflowRevision.cs
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

namespace Monai.Deploy.WorkflowManager.Common.Contracts.Models
{
[CollectionLocation("Workflows"), RuntimeVersion("1.0.4"), StartUpVersion("1.0.4")]
[CollectionLocation("Workflows"), RuntimeVersion("1.0.4")]
public class WorkflowRevision : ISoftDeleteable, IDocument
{
[BsonId]
Expand Down
Loading