Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding new plugin #303

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

adding new plugin #303

wants to merge 7 commits into from

Conversation

neildsouth
Copy link
Collaborator

Description

Adds a new plugin that simply saves files to local storage, intended for use where files as being stored on a NAS/SAN

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 101 lines in your changes are missing coverage. Please review.

Comparison is base (2361edd) 79.40979% compared to head (6565bd7) 79.77755%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #303         +/-   ##
===================================================
+ Coverage   79.40979%   79.77755%   +0.36776%     
===================================================
  Files             38          47          +9     
  Lines           1491        1978        +487     
  Branches          78         123         +45     
===================================================
+ Hits            1184        1578        +394     
- Misses           268         339         +71     
- Partials          39          61         +22     
Flag Coverage Δ
unittests 79.77755% <79.63710%> (+0.36776%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../Plugins/Simple/SimpleStorage/ConfigurationKeys.cs 100.00000% <100.00000%> (ø)
src/Plugins/Simple/SimpleStorage/HashCreator.cs 100.00000% <100.00000%> (ø)
src/Storage/API/StorageConnectionException.cs 33.33333% <33.33333%> (ø)
...lugins/Simple/SimpleStorage/ServiceRegistration.cs 0.00000% <0.00000%> (ø)
...e/SimpleStorage/Exceptions/FileCorruptException.cs 33.33333% <33.33333%> (ø)
.../SimpleStorage/Exceptions/FileNotFoundException.cs 0.00000% <0.00000%> (ø)
src/Storage/API/VerifyObjectsException.cs 0.00000% <0.00000%> (ø)
...s/Simple/SimpleStorage/SimpleStorageHealthCheck.cs 0.00000% <0.00000%> (ø)
...Plugins/Simple/SimpleStorage/HealthCheckBuilder.cs 0.00000% <0.00000%> (ø)
...rc/Plugins/Simple/Tests/Unit/SimpleStorageTests.cs 95.74468% <95.74468%> (ø)
... and 1 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2361edd...6565bd7. Read the comment docs.

Signed-off-by: Neil South <[email protected]>
Signed-off-by: Neil South <[email protected]>
Signed-off-by: Neil South <[email protected]>
Signed-off-by: Neil South <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant