Add support for setting libcuda verbosity #563
Draft
+32
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: Project-HAMi#544 Signed-off-by: Tigran Grigoryan <[email protected]>
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add support for setting
LIBCUDA_LOG_LEVELduring admission.Which issue(s) this PR fixes:
Resolves: #544
Special notes for your reviewer:
I added a new function,
setOrUpdateEnvVar, as I couldn’t find an existing alternative in the source code. However, I believe it should be placed in a more accessible location other thanpkg/device/nvidia/device.go.Does this PR introduce a user-facing change?:
Default log level stays the same.
Users should upgrade their
values.yamlfiles if they want to change verbosity level.