Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcomingevent #43

Conversation

Fenil-1
Copy link
Contributor

@Fenil-1 Fenil-1 commented Dec 26, 2024

Resolves #3

Added UpcomingEventCard component using props ..
Register button does not do anything rn as mentioned ..

Copy link

netlify bot commented Dec 26, 2024

Deploy Preview for au-pclub ready!

Name Link
🔨 Latest commit cf6e13e
🔍 Latest deploy log https://app.netlify.com/sites/au-pclub/deploys/676eb87c5854400008e53dd2
😎 Deploy Preview https://deploy-preview-43--au-pclub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Saumya40-codes
Copy link
Member

LGTM 🚀
looks perfect

Just few suggestions (please review the below comments)

@Saumya40-codes
Copy link
Member

Saumya40-codes commented Dec 26, 2024

The codebase you were/are currently working on might be few commits behind the current codebase which is causing the merge conflict

image

when you do/did git checkout upcomingevent it takes the state of code during that time and creates a kind of new copy but it doesnt remain in sync with whatever is updating in the main codebase.

A merge conflict happens when changes in your branch and the main branch affect the same parts of the file(s). Git doesn't know which changes to keep.

Now, for this you can do one of the following option:

  1. As you saw in image (or above merge conflict message), you can completely replace src/App.jsx and src/components/Navbar.css with the current repo's latest change and commit/push again here . (imo this will be easy way as in your current changes, we wont strictly need the updates that are being made in those two files)

check here


  1. You can go to cloned repository and make sure your branch is main and click on Sync Fork and then update branch now your main branch is up-to-date with that of our codebase.

in your local setup, run following commands.

git checkout main
git pull
git checkout upcomingevent
git merge main

now you'll see that merge conflict has occurred message. Now if your using vs code, go to file where merge conflict has occured, and click open in merge editor kind option there. Select Accept Incoming Changes this will prioritize the main (latest branch) change in both the file. Once you do this for both file and all conflicts.

Run normal, git add ., git commit and git push commands again.

@Saumya40-codes
Copy link
Member

Imo it will be simple and right for now that you overwrite src/App.jsx and src/components/Navbar.css with the current code(the one in this repo) as its ok if what changes you've made in those gets removed as it was going to be changed anyways.

@Saumya40-codes
Copy link
Member

Imo it will be simple and right for now that you overwrite src/App.jsx and src/components/Navbar.css with the current code(the one in this repo) as its ok if what changes you've made in those gets removed as it was going to be changed anyways.

If you didn't understand anything, do comment as I can make those changes from my side as well, but I thought it will be better if you make updates there !

@Fenil-1
Copy link
Contributor Author

Fenil-1 commented Dec 26, 2024

Imo it will be simple and right for now that you overwrite src/App.jsx and src/components/Navbar.css with the current code(the one in this repo) as its ok if what changes you've made in those gets removed as it was going to be changed anyways.

If you didn't understand anything, do comment as I can make those changes from my side as well, but I thought it will be better if you make updates there !

I merged with main .. can you please check it once ?

@Saumya40-codes
Copy link
Member

Perfect now 🚀

@Saumya40-codes
Copy link
Member

Thanks @Fenil-1 for this PR

@Saumya40-codes Saumya40-codes merged commit 5222abc into Programming-Club-Ahmedabad-University:main Dec 27, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Design]: Develop the Upcoming Event Card Component
2 participants