Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributors logo #41

Conversation

vrunda2005
Copy link
Contributor

Related Issue

Fixes #26: [CI] Contributors logo in README.md doesn't update in real-time

Description

  • Added a new workflow file: workflows/contributors_update.yml.
  • Updated the README.md section where the contributors' logos are displayed to ensure it updates in real-time.

Checklist

Please ensure the following before submitting the PR:

  • I have read and followed the guidelines in the CODE_OF_CONDUCT.md file.
  • I have followed the design specified in the Figma file (if applicable).

Additional Comments

  • Through this PR, I learned about GitHub Actions.
  • However, I am still unsure how to verify if the workflow is functioning correctly. Any guidance on testing it would be appreciated.

Copy link

netlify bot commented Dec 26, 2024

Deploy Preview for au-pclub ready!

Name Link
🔨 Latest commit 4a704ae
🔍 Latest deploy log https://app.netlify.com/sites/au-pclub/deploys/676fea5a10a8ea0008dcc746
😎 Deploy Preview https://deploy-preview-41--au-pclub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Saumya40-codes
Copy link
Member

  • However, I am still unsure how to verify if the workflow is functioning correctly. Any guidance on testing it would be appreciated.

You can create a private repository and add the same workflow in .github/workflows/ directory there, then can try out by pushing (or any other action need to trigger that workflow)

@vrunda2005
Copy link
Contributor Author

Does this work?In my private repo this code is working.
Screenshot 2024-12-26 210651

@Saumya40-codes
Copy link
Member

Saumya40-codes commented Dec 27, 2024

Thanks @vrunda2005 !

The main idea was to completely remove dependency on contrib.rocks as it takes time for it get updated.

You current commit make sure that contributors names are updated but it still currently depends on contrib.rocks for logo images, for this with name you can fetch an image url aswell and align them in the same way.

something like

CONTRIBUTORS_LOGOS="https://api.github.com/repos/${REPO_NAME}/contributors?per_page=10" | \
            jq -r '.[] | "- [@\(.login)](https://github.com/\(.login)) <img src=\"\(.avatar_url)\" alt=\"avatar\" style = \ "necessary styles required \"> "')

@vrunda2005
Copy link
Contributor Author

Now I have changed this. I have tried to image in the circle but not working.
Screenshot 2024-12-28 015035

push:
branches:
- main
schedule:
Copy link
Member

@Saumya40-codes Saumya40-codes Dec 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this schedule part.

Contributors will change only during the push (if any new) so no need to run this workflow after every specific time period

@Saumya40-codes
Copy link
Member

Look right 🙌

Thanks.

@Saumya40-codes Saumya40-codes merged commit 3285d22 into Programming-Club-Ahmedabad-University:main Dec 28, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants