fix: Re-place .cpp and .hpp files into the right folders #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I am not a big fan of using the absolute path to be honest...
In my branches I used for example:
#include <utils.hpp>
and it worked. What do you think?
| @@ -1,6 +1,7 @@ | |||
| cmake_minimum_required(VERSION 3.27) | |||
| project("Pokemon_Project" VERSION 999.0.0) | |||
| set(CMAKE_CXX_STANDARD 17) | |||
| set(CMAKE_COMPILE_WARNING_AS_ERROR ON) | |||
There was a problem hiding this comment.
This is to be sure that warnings will be solved and not left there for "the future people"?
| @@ -9,7 +9,7 @@ namespace utils { | |||
| int y; | |||
| }; | |||
|
|
|||
| typedef enum Direction : uint8_t { | |||
| enum Direction : uint8_t { | |||
There was a problem hiding this comment.
Same af for the Tile.hpp comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.