Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add order history page #301

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AureRita
Copy link
Contributor

Questions Answers
Description? Add Order History from develop page
Type? improvement /
BC breaks? no
Deprecations? no
Fixed ticket?
Sponsor company Prestashop Core
How to test? CI is green

Comment on lines +8 to +23
getNumberOfOrders(page: Page): Promise<number>;
getOrderHistoryDetails(page: Page, row?: number): Promise<OrderHistory>;
isReorderLinkVisible(page: Page, orderRow?: number): Promise<boolean>;
clickOnReorderLink(page: Page, orderRow?: number): Promise<void>;
getOrderStatus(page: Page, orderRow?: number): Promise<string>;
isInvoiceVisible(page: Page, orderRow?: number): Promise<boolean>;
getOrderIdFromInvoiceHref(page: Page, orderRow?: number): Promise<string>;
downloadInvoice(page: Page, row?: number): Promise<string | null>;
goToDetailsPage(page: Page, orderRow?: number): Promise<void>;
goToOrderDetailsPage(page: Page, orderID?: number): Promise<void>;
clickOnBackToYourAccountLink(page: Page): Promise<void>;
clickOnHomeLink(page: Page): Promise<void>;
isBoxMessagesSectionVisible(page: Page): Promise<boolean>;
isMessageRowVisible(page: Page, row?: number): Promise<boolean>;
getMessageRow(page: Page, row?: number): Promise<string>;
sendMessage(page: Page, messageText: OrderHistoryMessage): Promise<string>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sort by alphabetical order

* @class
* @extends FOBasePage
*/
class OrderHistoryPage extends FOBasePage implements FoOrderHistoryPageInterface {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class OrderHistoryPage extends FOBasePage implements FoOrderHistoryPageInterface {
class FoOrderHistoryPage extends FOBasePage implements FoOrderHistoryPageInterface {

Comment on lines +262 to +263
const orderHistoryPage = new OrderHistoryPage();
export {orderHistoryPage, OrderHistoryPage};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const orderHistoryPage = new OrderHistoryPage();
export {orderHistoryPage, OrderHistoryPage};
const foOrderHistoryPage = new FoOrderHistoryPage();
export {foOrderHistoryPage, FoOrderHistoryPage};


/* eslint-disable global-require, @typescript-eslint/no-require-imports, @typescript-eslint/no-var-requires */
function requirePage(): FoOrderHistoryPageInterface {
return require('@versions/develop/pages/FO/classic/myAccount/orderHistory').orderHistoryPage;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return require('@versions/develop/pages/FO/classic/myAccount/orderHistory').orderHistoryPage;
return require('@versions/develop/pages/FO/classic/myAccount/orderHistory').foOrderHistoryPage;

Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedbacks

Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for review
Development

Successfully merging this pull request may close these issues.

2 participants