Add data and pages for autoupgrade module #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nesrineabdmouleh
commented
Dec 18, 2024
nesrineabdmouleh
commented
| Questions | Answers |
|---|---|
| Description? | Add data and pages for autoupgrade module |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | no |
| Sponsor company | @PrestaShopCorp |
| How to test? | Ci is 🍏 |
Progi1984
reviewed
Dec 18, 2024
Comment on lines
9
to
11
| if (semver.gte(psVersion, '0.0.0')) { | ||
| return require('@versions/develop/pages/BO/modules/autoupgrade'); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (semver.gte(psVersion, '0.0.0')) { | |
| return require('@versions/develop/pages/BO/modules/autoupgrade'); | |
| } |
Progi1984
reviewed
Dec 18, 2024
Comment on lines
2
to
6
| import testContext from '@utils/test'; | ||
| import semver from 'semver'; | ||
|
|
||
| const psVersion = testContext.getPSVersion(); | ||
|
|
There was a problem hiding this comment.
Suggested change
| import testContext from '@utils/test'; | |
| import semver from 'semver'; | |
| const psVersion = testContext.getPSVersion(); |
Progi1984
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.