Add Honduras Localization Pack

[vienafromm]

Honduras Localization Pack

Questions	Answers
Description?	Honduras Localization Pack
Type?	Improvement
BC breaks?	yes
Deprecations?	yes
Fixed ticket?	Fixes
How to test?	Test it
Possible impacts?	Add it to the localization pack

[PierreRambaud]

@Julievrz I don't know if you can check it about translations.
@PrestaShop/product-team Could you validate unit information please?

[Julievrz]

It looks ok for the language and the ISO code. The Spanish (HN) project is not available on Crowdin at the moment but we will be able to add it later on if translators are interested in working on it.

[matks]

Hi @vienafromm and @Julievrz I'm afraid the following informations in the PR are not helpful 😅

BC breaks?	yes
Deprecations?	yes
Fixed ticket?	Fixes
How to test?	Test it

How do we test this works?
Is there deprecations? If yes, what are they?
Is there BC breaks? If yes, what are they?

Without these informations I dont see how we can validate and merge this PR

[MatShir]

@matks are these questions and form required for the core project, does it fit here ? Localization file can be updated by non-tech people I guess. So BC and Deprecations can be tough questions.

[matks]

@matks are these questions and form required for the core project, does it fit here ? Localization file can be updated by non-tech people I guess. So BC and Deprecations can be tough questions.

We can remove them indeed, but then why say "Yes" 😅 because now I'm afraid. I just want to understand the answer to these. If the answer is "I did not know so I wrote Yes" it's OK 😉 but I need to be informed

[vienafromm]

@matks Correct, I did not know so I wrote Yes. I don't know what BC and Deprecations are. :S

[rickygzz]

@matks @Progi1984

Could you take a look at this PR? It seems it has been approved and it is ready to be merged.

(I would like to add <states> tag to this file).

Thank you, have a great day

[Progi1984]

@rickygzz Before merging this file, we need that @Julievrz, the content manager of the project, validates this PR.

[Julievrz]

@rickygzz Before merging this file, we need that @Julievrz, the content manager of the project, validates this PR.

It's ok. As I said a while ago, it looks ok for the language and the ISO code: at least for the currency ISO code which is HNL. For the language ISO code, it's HND but the Spanish (HN) project is not available on Crowdin at the moment. We'll still be able to add it later on if translators are interested in working on it.

Information about the metric system seems ok as well.

[rickygzz]

@Progi1984 ping!

[khouloudbelguith]

Hi @vienafromm,

I tried to install the honduras pack.
But I found that the currency symbol = L

• BO
  

• FO
  

• Pdf
  

I checked the Product page > Pricing Tab => I have different symbols

@Julievrz what do you think? what is the exact symbol should be displayed?

Thanks!

[Julievrz]

Hi @vienafromm,

I tried to install the honduras pack. But I found that the currency symbol = L

• BO
  
• FO
  
• Pdf
  

I checked the Product page > Pricing Tab => I have different symbols

@Julievrz what do you think? what is the exact symbol should be displayed?

Thanks!

It seems that both are acceptable. HNL is the ISO 4217. Maybe @rickygzz has more insights?

[vienafromm]

Hi @vienafromm,
I tried to install the honduras pack. But I found that the currency symbol = L

• BO
  
• FO
  
• Pdf
  

I checked the Product page > Pricing Tab => I have different symbols
@Julievrz what do you think? what is the exact symbol should be displayed?
Thanks!

It seems that both are acceptable. HNL is the ISO 4217. Maybe @rickygzz has more insights?

Sorry, it was my mistake. Yes, the correct currency is HNL (It means Honduran Lempira)

Thanks for following up on this! <3

Hugs,
Viena

[vienafromm]

Change approved!

[Julievrz]

Change approved!

Thanks @vienafromm, let's go with "HNL" then. :-)

[khouloudbelguith]

Hi @vienafromm,

I still have the same issues with PS1785 & the develop branch.
I tried these steps:

1. Install PS1785 with English language & France country
2. Add the new file hn.xml in the path PrestaShop/localization/
3. Go to BO > International > Localization page > Import the Honduras pack
4. Go to BO > International > Localization > Currencies page
5. See error, the symbol is incorrect
6. Go to FO > Select the new currency
7. See error
8. Go to BO > Catalog > Product page > edit a product > Pricing tab
9. See error

Did I miss something?

Thanks!

[rickygzz]

Hello,

It seems HNL and L are both ok.

The first one is the currency ISO 4217 code (like USD or EUR) and the second one is the sign (like $ or €) as stated in their country laws.

So in my opinion, the xml file currency attributes should be iso_code="HNL" sign="L" (instead of HNL), as follows:

        	<currencies>
                   	<currency name="Lempira" iso_code="HNL" iso_code_num="340" sign="L" blank="1" format="2" decimals="1" />
        	</currencies>

However, I was intrigued why it didn't follow the proposed XML file during the QA. It seems PS pulls its data from the standardized CLDR database. The currency data for Honduran Lempira is pulled from this file PrestaShop/PrestaShop/localization/CLDR/core/common/main/es.xml line 6461.

That being said, it seems anytime soon we should clean this PrestaShop/LocalizationFiles repository and remove the currency tags, since it seems its not being used anymore.

Hope it helps,

Source:

The ISO three-letter alphabetic code for its currency is HNL (see ISO 4217 https://www.iso.org/iso-4217-currency-codes.html which refers to https://www.six-group.com/en/products-services/financial-information/data-standards.html and it offers a list updated up to April 1st 2022)

The currency symbol (sign) is L. This as stated in Wikipedia and in the Law Ley Monetaria Decreto - No. 51-1950 in its first article

Articulo 1
La unidad monetaria de Honduras es el Lempira, cuyo símbolo es L. El Lempira se divide en cien partes denominadas centavos.

Article 1
The monetary unit of Hundras is the Lempira, whose symbol is L. The Lempira is divided into one hundred parts called cents.

Outdated

[eternoendless]

It seems PS pulls its data from the standardized CLDR database. The currency data for Honduran Lempira is pulled from this file PrestaShop/PrestaShop/localization/CLDR/core/common/main/es.xml line 6461.

That being said, it seems anytime soon we should clean this PrestaShop/LocalizationFiles repository and remove the currency tags, since it seems its not being used anymore.

You are completely right. The problem is that older versions of PrestaShop retrieve localization files from the same source as newer versions. We need to figure out a way to fix that.