chore(prometheus-prefect-exporter): make further use of common library chart #356

mitchnielsen · 2024-07-09T17:24:29Z

Summary

Makes further use of Bitnami's common library chart.

Closes PrefectHQ/prometheus-prefect-exporter#32

Testing

Defaults

A very rudimentary test is just to compare the default chart output on main and on this branch and confirm that there are no differences:

$ helm template test ../main/charts/prometheus-prefect-exporter > output.main.yaml

$ helm template test charts/prometheus-prefect-exporter > output.branch.yaml

$ dyff between output.{main,branch}.yaml
     _        __  __
   _| |_   _ / _|/ _|  between output.main.yaml, three documents
 / _' | | | | |_| |_       and output.branch.yaml, three documents
| (_| | |_| |  _|  _|
 \__,_|\__, |_| |_|   returned no differences
        |___/

Specific overrides

Setting the image:

$ helm template test charts/prometheus-prefect-exporter --set image.repository=prometheus-test --show-only templates/deployment.yaml | yq '.spec.template.spec.containers[0].image'
prometheus-test:1.1.0

Setting the name override:

$ helm template test charts/prometheus-prefect-exporter --set nameOverride=prometheusv2 --show-only templates/deployment.yaml | yq '.metadata.name'
test-prometheusv2

Uses the common name template to replace the one we defined that generates the exporter name.

Uses the 'common.names.fullname' template to replace the one we defined that generates the exporter full name.

Uses the common chart template for use when defining common labels.

Uses the common matchLabels template to replace the one we had defined.

Uses the common standard labels template to replace the one we had defined.

Uses the common image template to replace our definition of each component. No need to default to the Chart AppVersion because image.tag has a default value, so it will never be triggered.

mitchnielsen · 2024-07-09T19:41:00Z

Until we address #304, I'll set up some specific tests to confirm the changes here work as expected and then open it up for review.

jamiezieziula

thank you!! all code looks good to me 🚀

mitchnielsen added 6 commits July 9, 2024 11:39

Use 'common.names.name' common template

fd847d2

Uses the common name template to replace the one we defined that generates the exporter name.

Use 'common.names.fullname' common template

b119e0b

Uses the 'common.names.fullname' template to replace the one we defined that generates the exporter full name.

Use 'common.names.chart' common template

3e32920

Uses the common chart template for use when defining common labels.

Use 'common.labels.matchLabels' common template

470f418

Uses the common matchLabels template to replace the one we had defined.

Use 'common.labels.standard' common template

7c6f95d

Uses the common standard labels template to replace the one we had defined.

Use 'common.images.image' common template

dfd662a

Uses the common image template to replace our definition of each component. No need to default to the Chart AppVersion because image.tag has a default value, so it will never be triggered.

mitchnielsen added the maintenance label Jul 9, 2024

mitchnielsen self-assigned this Jul 9, 2024

Merge branch 'main' into exporter-use-common-chart

7113ce1

mitchnielsen marked this pull request as ready for review July 17, 2024 21:36

mitchnielsen requested a review from a team as a code owner July 17, 2024 21:36

jamiezieziula approved these changes Jul 17, 2024

View reviewed changes

mitchnielsen merged commit a987732 into main Jul 17, 2024
16 checks passed

mitchnielsen deleted the exporter-use-common-chart branch July 17, 2024 21:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(prometheus-prefect-exporter): make further use of common library chart #356

chore(prometheus-prefect-exporter): make further use of common library chart #356

mitchnielsen commented Jul 9, 2024 •

edited

Loading

mitchnielsen commented Jul 9, 2024

jamiezieziula left a comment

chore(prometheus-prefect-exporter): make further use of common library chart #356

chore(prometheus-prefect-exporter): make further use of common library chart #356

Conversation

mitchnielsen commented Jul 9, 2024 • edited Loading

Summary

Testing

Defaults

Specific overrides

mitchnielsen commented Jul 9, 2024

jamiezieziula left a comment

Choose a reason for hiding this comment

mitchnielsen commented Jul 9, 2024 •

edited

Loading