Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events.py #365

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

events.py #365

wants to merge 4 commits into from

Conversation

Innovatorcloudy
Copy link

  • Simplified conditional checks and utilized get for dictionary access
  • Added logging statements to key points for better traceability.
  • Improved the structure of message transformations, emphasizing clarity and maintainability

Simplified conditional checks and utilized get for dictionary access
Added logging statements to key points for better traceability.
Improved the structure of message transformations, emphasizing clarity and maintainability
@Innovatorcloudy
Copy link
Author

@jlowin Sir can you review and merge it

Copy link
Member

@jlowin jlowin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes here that are good like class docstrings, some that I think are unnecessary like debug logs for events that are already debug-logged elsewhere, and some that are contrary to how this codebase works, like replacing private validators with public ones and importing List from typing. I would accept the first type but the latter add to cognitive burden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants