-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement LogOutputWindow for Logging #5065
base: main
Are you sure you want to change the base?
Conversation
@andyleejordan I think you'll like this new utility function too for taking action on a config change: vscode-powershell/src/utils.ts Lines 89 to 113 in d617194
EDIT: I see a flaw here, will fix :) |
9471227
to
69e3209
Compare
Currently pending microsoft/vscode-languageserver-node#1116 otherwise all of our log messages surface as "trace" with a header which is not ideal. |
This is going to be so nice though. |
No longer pending that, I wrote a new trace handler :). Currently debating if I want to add realtime logging changes based on changing the LSP setting to this PR or save that for another one. |
Implements the
LogOutputWindow
vscode API for PowerShell extension and PSES logs received via LSP.Recording.2024-10-18.170017.mp4
This has several benefits:
Issue Reporter
, there's a contribution API for issue reporter where we can gather additional data as well (PR forthcoming)A sister PR for PSES (everything coming across the LSP currently shows up as info) is forthcoming but is not urgently necessary to merge this PR.