-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cdp): disallow hog code modification #28142
Merged
Merged
+138
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR adds a security measure to prevent modification of transformation code through the API by introducing a new HOG_TRANSFORMATIONS_ENABLED
setting.
- Added validation in
posthog/api/hog_function.py
to block transformation code modifications when disabled - Added new setting
HOG_TRANSFORMATIONS_ENABLED = False
inee/settings.py
to disable transformations by default - Added test coverage in
posthog/api/test/test_hog_function.py
to verify transformation code cannot be modified while destination code changes remain allowed - Setting is hardcoded to
False
without environment variable configuration, which may need consideration
3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
benjackwhite
requested changes
Jan 31, 2025
benjackwhite
requested changes
Jan 31, 2025
benjackwhite
approved these changes
Jan 31, 2025
meikelmosby
force-pushed
the
feat/cdp/disallow-hog-code-modification
branch
from
January 31, 2025 17:26
634e27e
to
00b1597
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We hide modification of hog code for transformations in the frontend but we also want to prohibit to make modifications to hog code in the backend.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?