feat: 🎸 ensure one vote per signer for multiSig proposals #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashantasdeveloper
force-pushed
the
feat/settlements-v2
branch
from
7bfc287
to
5419282
Compare
when a multiSig signer changes their vote, the vote record will now be updated instead of inserting a second vote. Proposal approval/rejection counts will now be decremented in this case
prashantasdeveloper
force-pushed
the
improve-multi-votes
branch
from
6fa0239
to
4a7e67f
Compare
|
|
I merged in 7.x into settlements-v2 (since the v2 one had merge conflicts with alpha). As a result when base branch was updated, I rebased this PR onto settlements-v2 to make it up to date @polymath-eric |
polymath-eric
requested review from
VictorVicente,
prashantasdeveloper and
sansan
as code owners
prashantasdeveloper
approved these changes
Sep 12, 2024
|
/fast-forward |
|
🎉 This PR is included in version 16.0.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 16.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when a multiSig signer changes their vote, the vote record will now be updated instead of inserting a second vote. Proposal approval/rejection counts will now be decremented in this case
Breaking Changes
JIRA Link
DA-1289
Checklist