Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🎸 Add PolyxTransaction entity #113

Merged
merged 18 commits into from
Jul 26, 2023
Merged

feat: 🎸 Add PolyxTransaction entity #113

merged 18 commits into from
Jul 26, 2023

Conversation

prashantasdeveloper
Copy link
Contributor

Description

Adds a new entity to track all the POLYX transactions

Breaking Changes

NA

JIRA Link

DA-195

Checklist

  • Updated the Readme.md (if required) ?

@prashantasdeveloper
feat: 🎸 Add PolyxTransaction entity
fb961ef 
Adds a new entity to track all the POLYX transactions
polymath-eric
polymath-eric reviewed Jan 10, 2023
View reviewed changes
Copy link
Contributor

@polymath-eric polymath-eric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Will look again once we have all events

@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

polymath-eric
polymath-eric reviewed Apr 13, 2023
View reviewed changes
Copy link
Contributor

@polymath-eric polymath-eric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get the 80% part. Multiplying by a float value seems risky here from a numbers lining up 100% point of view. I trust BigInt wouldn't cause us issues, but it seems kind of arbitrary to me as well.

Does the chain expose this ratio in an RPC somewhere? Is it a constant for all blocks always, or can it be adjusted?

src/mappings/entities/mapPolyxTransaction.ts Outdated Show resolved Hide resolved
polymath-eric
polymath-eric reviewed Apr 20, 2023
View reviewed changes
db/migrations/9.4.05.sql Outdated Show resolved Hide resolved
db/migrations/9.4.05.sql Outdated Show resolved Hide resolved
scripts/run-sql.ts Outdated Show resolved Hide resolved
src/mappings/entities/mapPolyxTransaction.ts Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented May 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@prashantasdeveloper prashantasdeveloper marked this pull request as ready for review July 25, 2023 07:30
@prashantasdeveloper prashantasdeveloper merged commit 6ac2210 into alpha Jul 26, 2023
2 checks passed
@prashantasdeveloper prashantasdeveloper deleted the feat/DA-195-polyx-transaction branch July 26, 2023 13:20
@polymath-eric
Copy link
Contributor

🎉 This PR is included in version 9.7.0-alpha.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@polymath-eric
Copy link
Contributor

🎉 This PR is included in version 9.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorVicente VictorVicente VictorVicente approved these changes

@sansan sansan Awaiting requested review from sansan sansan is a code owner

@polymath-eric polymath-eric Awaiting requested review from polymath-eric polymath-eric is a code owner

Assignees
No one assigned
Labels
released on @alpha released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prashantasdeveloper @polymath-eric @VictorVicente