Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🎸 make venueId optional for createInstruction #290

Merged
merged 1 commit into from
Oct 21, 2024
Merged

feat: 🎸 make venueId optional for createInstruction #290

merged 1 commit into from
Oct 21, 2024

Conversation

sansan
Copy link
Contributor

@sansan sansan commented Oct 10, 2024

JIRA Link

https://polymesh.atlassian.net/browse/DA-1302

Changelog / Description

  • makes the venueId optional in settlements service
  • adds a new endpoint under settlements controller to create an instruction withouth venueId

Checklist -

  • New Feature ?
  • Updated swagger annotation (if API structure is changed) ?
  • Unit Test (if possible) ?

@sansan sansan changed the title Feat/DA-1302 feat: 🎸 make venueId optional for createInstruction Oct 10, 2024
@sansan sansan force-pushed the feat/DA-1302 branch 2 times, most recently from bc1b60d to 0c260e7 Compare October 10, 2024 19:54
@sansan sansan changed the base branch from ticker-support to v7-chain-support October 11, 2024 13:57
@prashantasdeveloper prashantasdeveloper changed the base branch from v7-chain-support to ticker-support October 21, 2024 04:58
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Base automatically changed from ticker-support to v7-chain-support October 21, 2024 05:02
@prashantasdeveloper
Copy link
Contributor

/fast-forward

@polymath-eric polymath-eric merged commit 6697adf into v7-chain-support Oct 21, 2024
7 checks passed
@polymath-eric polymath-eric deleted the feat/DA-1302 branch October 21, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorVicente VictorVicente Awaiting requested review from VictorVicente VictorVicente is a code owner

@polymath-eric polymath-eric Awaiting requested review from polymath-eric polymath-eric is a code owner

@prashantasdeveloper prashantasdeveloper Awaiting requested review from prashantasdeveloper prashantasdeveloper is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sansan @prashantasdeveloper @polymath-eric