-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🎸 update sdk to v24.5.0 #275
Conversation
update sdk dependency to avoid warnings when connecting to a 6.3 chain
WalkthroughThe recent updates in the project involve upgrading the versions of various signing managers and the Polymesh SDK in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range and nitpick comments (1)
src/test-utils/consts.ts (1)
Line range hint
2-8
: Remove unused imports to clean up the code.- import { BigNumber } from '@polymeshassociation/polymesh-sdk'; - import { - Account, - PayingAccountType, - TransactionStatus, - TxTags, - } from '@polymeshassociation/polymesh-sdk/types';
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (3)
src/datastore/local-store/repos/__snapshots__/offline-tx.repo.spec.ts.snap
is excluded by!**/*.snap
src/datastore/postgres/repos/__snapshots__/offline-tx.repo.spec.ts.snap
is excluded by!**/*.snap
yarn.lock
is excluded by!**/*.lock
Files selected for processing (3)
- package.json (1 hunks)
- src/test-utils/consts.ts (1 hunks)
- src/transactions/dto/payload.dto.ts (5 hunks)
Files skipped from review due to trivial changes (1)
- package.json
Additional Context Used
Biome (1)
src/test-utils/consts.ts (1)
2-8: Some named imports are only used as types.
Path-based Instructions (2)
src/test-utils/consts.ts (2)
Pattern
**/*.ts
: Review the JavaScript code for conformity with the Semi-Standard style guide, highlighting any deviations.
Pattern
**/*.ts
: Analyze the logic of the code and the efficiency of the algorithms used. Suggest improvements if any inefficient algorithms are found.src/transactions/dto/payload.dto.ts (2)
Pattern
**/*.ts
: Review the JavaScript code for conformity with the Semi-Standard style guide, highlighting any deviations.
Pattern
**/*.ts
: Analyze the logic of the code and the efficiency of the algorithms used. Suggest improvements if any inefficient algorithms are found.
Additional comments not posted (1)
src/test-utils/consts.ts (1)
35-35
: Change to hexadecimal format forblockNumber
is consistent with system-wide updates.
🎉 This PR is included in version 5.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
JIRA Link
None
Changelog / Description
update sdk dependency to avoid warnings when connecting to a 6.3 chain
Checklist -
Summary by CodeRabbit
New Features
Bug Fixes
Improvements