Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 update sdk to v24.5.0 #275

Merged
merged 1 commit into from
May 29, 2024
Merged

feat: 🎸 update sdk to v24.5.0 #275

merged 1 commit into from
May 29, 2024

Conversation

polymath-eric
Copy link
Contributor

@polymath-eric polymath-eric commented May 28, 2024

JIRA Link

None

Changelog / Description

update sdk dependency to avoid warnings when connecting to a 6.3 chain

Checklist -

  • New Feature ?
  • Updated swagger annotation (if API structure is changed) ?
  • Unit Test (if possible) ?
  • Updated the Readme.md (if required) ?

Summary by CodeRabbit

  • New Features

    • Improved transaction handling with updated Polymesh SDK and signing managers.
  • Bug Fixes

    • Corrected block number initialization for offline transactions.
  • Improvements

    • Enhanced transaction payload formatting with standardized prefixes for better consistency and interoperability.

update sdk dependency to avoid warnings when connecting to a 6.3 chain
Copy link

coderabbitai bot commented May 28, 2024

Walkthrough

The recent updates in the project involve upgrading the versions of various signing managers and the Polymesh SDK in the package.json file. Additionally, there are modifications to the initialization values in consts.ts and updates to property declarations in payload.dto.ts to include a 0x prefix.

Changes

File Change Summary
package.json Updated versions for fireblocks-signing-manager, hashicorp-vault-signing-manager, local-signing-manager, and polymesh-sdk.
src/test-utils/consts.ts Changed blockNumber value in the offlineTx object from '-1' to '0x01'.
src/transactions/dto/payload.dto.ts Added 0x prefix to various property values in the PayloadDto class.

In code, we weave a tale so grand,
With updates fresh, our work will stand.
From zero to hex, the blocks align,
And SDKs in perfect line.
With every change, our code does sing,
Here’s to progress, and all it brings! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to full the review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range and nitpick comments (1)
src/test-utils/consts.ts (1)

Line range hint 2-8: Remove unused imports to clean up the code.

- import { BigNumber } from '@polymeshassociation/polymesh-sdk';
- import {
-   Account,
-   PayingAccountType,
-   TransactionStatus,
-   TxTags,
- } from '@polymeshassociation/polymesh-sdk/types';
Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits Files that changed from the base of the PR and between 85e1922 and d17eb12.
Files ignored due to path filters (3)
  • src/datastore/local-store/repos/__snapshots__/offline-tx.repo.spec.ts.snap is excluded by !**/*.snap
  • src/datastore/postgres/repos/__snapshots__/offline-tx.repo.spec.ts.snap is excluded by !**/*.snap
  • yarn.lock is excluded by !**/*.lock
Files selected for processing (3)
  • package.json (1 hunks)
  • src/test-utils/consts.ts (1 hunks)
  • src/transactions/dto/payload.dto.ts (5 hunks)
Files skipped from review due to trivial changes (1)
  • package.json
Additional Context Used
Biome (1)
src/test-utils/consts.ts (1)

2-8: Some named imports are only used as types.

Path-based Instructions (2)
src/test-utils/consts.ts (2)

Pattern **/*.ts: Review the JavaScript code for conformity with the Semi-Standard style guide, highlighting any deviations.


Pattern **/*.ts: Analyze the logic of the code and the efficiency of the algorithms used. Suggest improvements if any inefficient algorithms are found.

src/transactions/dto/payload.dto.ts (2)

Pattern **/*.ts: Review the JavaScript code for conformity with the Semi-Standard style guide, highlighting any deviations.


Pattern **/*.ts: Analyze the logic of the code and the efficiency of the algorithms used. Suggest improvements if any inefficient algorithms are found.

Additional comments not posted (1)
src/test-utils/consts.ts (1)

35-35: Change to hexadecimal format for blockNumber is consistent with system-wide updates.

src/transactions/dto/payload.dto.ts Show resolved Hide resolved
@prashantasdeveloper prashantasdeveloper merged commit d17eb12 into master May 29, 2024
6 checks passed
@prashantasdeveloper prashantasdeveloper deleted the new-alpha branch May 29, 2024 06:20
@polymesh-bot
Copy link
Contributor

🎉 This PR is included in version 5.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants