Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 🤖 smaller docker image #201

Closed
wants to merge 1 commit into from
Closed

chore: 🤖 smaller docker image #201

wants to merge 1 commit into from

Conversation

polymath-eric
Copy link
Contributor

JIRA Link

N/A

Changelog / Description

removes dev dependency + use alpine as base to create significantly smaller docker images.

Previous images were 2.4GB images, this change brings them to a more reasonable 367 MB.

Checklist -

  • New Feature ?
  • Updated swagger annotation (if API structure is changed) ?
  • Unit Test (if possible) ?
  • Updated the Readme.md (if required) ?

@polymath-eric
chore: 🤖 smaller docker image
ee3b69b 
removes dev dependency + use alpine as base to create significantly
smaller docker images
@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 3 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@polymath-eric
Copy link
Contributor Author

closing this, made it a separate commit in the dual SDK #202 PR instead

@polymath-eric polymath-eric deleted the smaller-docker-image branch August 11, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorVicente VictorVicente Awaiting requested review from VictorVicente VictorVicente will be requested when the pull request is marked ready for review VictorVicente is a code owner

@prashantasdeveloper prashantasdeveloper Awaiting requested review from prashantasdeveloper prashantasdeveloper will be requested when the pull request is marked ready for review prashantasdeveloper is a code owner

@sansan sansan Awaiting requested review from sansan sansan will be requested when the pull request is marked ready for review sansan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@polymath-eric