Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paper tooltip fit to visible bounds. #155

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jpalmer
Copy link

@jpalmer jpalmer commented Jul 8, 2021

There are 3 cases that can happen with fit to visible bounds (Using left/right for simplicity here)

  1. Off the right of the screen
  2. Off the left of the screen
  3. In the middle of the screen (no adjustment required)

Paper tooltip failed to handle case (3).

Fix that.

@jpalmer jpalmer requested a review from bicknellr as a code owner July 8, 2021 00:53
@google-cla
Copy link

google-cla bot commented Jul 8, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

There are 3 cases that can happen with fit to visible bounds (Using left/right for simplicity here)

1) Off the right of the screen
2) Off the left of the screen
3) In the middle of the screen (no adjustment required)

Paper tooltip failed to handle case (3).

Fix that.
@bicknellr
Copy link
Contributor

Imported for testing as http://cl/384586759. I think our test infra for everything in https://github.com/PolymerElements broke recently due to travis-ci.org being turned down so I'll have to try this out locally.

@jpalmer
Copy link
Author

jpalmer commented Jul 21, 2021

Friendly ping :)

@jpalmer
Copy link
Author

jpalmer commented Jul 29, 2021

ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants