Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial selected tab not visible #227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joshdifabio
Copy link

If the tabs are scrollable and the initial selected tab is not visible (i.e. it is off to the right), it should be scrolled to automatically. At present, this is not the case, because _scrollToSelectedIfNeeded() is not called when there is no 'old' tab.

If the tabs are scrollable and the initial selected tab is not visible (i.e. it is off to the right),
it should be scrolled to automatically. At present, this is not the case.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@joshdifabio
Copy link
Author

I've now signed the CLA.

This PR should fix #175.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jun 9, 2018
@joshdifabio
Copy link
Author

@bicknellr Any chance you could take a look at this please? :)

@paladox
Copy link

paladox commented Jun 29, 2021

Need to fix merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants