Merge pull request #41 from PolymerElements/rictic-patch-1

Improve type safety of scroll method
PolymerElements · Apr 13, 2018 · f710846 · f710846
2 parents c36cc42 + efaf4f5
commit f710846
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/iron-scroll-target-behavior.d.ts b/iron-scroll-target-behavior.d.ts
@@ -107,7 +107,7 @@ declare namespace Polymer {
      * @param leftOrOptions The left position or scroll options
      * @param top The top position
      */
-    scroll(leftOrOptions: number|ScrollToOptions, top?: number): void;
+    scroll(leftOrOptions: number|{left: number, top: number}, top?: number): void;
 
     /**
      * Returns true if the scroll target is a valid HTMLElement.

diff --git a/iron-scroll-target-behavior.html b/iron-scroll-target-behavior.html
@@ -190,18 +190,22 @@
      * Scrolls the content to a particular place.
      *
      * @method scroll
-     * @param {number|!ScrollToOptions} leftOrOptions The left position or scroll options
+     * @param {number|!{left: number, top: number}} leftOrOptions The left position or scroll options
      * @param {number=} top The top position
      * @return {void}
      */
     scroll: function(leftOrOptions, top) {
-      var left = leftOrOptions;
+      var left;
 
       if (typeof leftOrOptions === 'object') {
         left = leftOrOptions.left;
         top = leftOrOptions.top;
+      } else {
+        left = leftOrOptions;
       }
 
+      left = left || 0;
+      top = top || 0;
       if (this.scrollTarget === this._doc) {
         window.scrollTo(left, top);
       } else if (this._isValidScrollTarget()) {