Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create NeoForge Profiles Update #5203

Open
wants to merge 5 commits into
base: v3_openjdk
Choose a base branch
from

Conversation

MovTery
Copy link
Contributor

@MovTery MovTery commented Mar 6, 2024

  • When creating a new profile, you can choose to create a NeoForge profile.
  • This will automatically fetch all the supported versions of NeoForge, allowing you to download and execute the installation files smoothly.
  • Currently, automatic installation is not supported.

@zkitefly
Copy link

zkitefly commented Mar 6, 2024

can you support 1.20.1 NeoForge please?

@MovTery
Copy link
Contributor Author

MovTery commented Mar 6, 2024

can you support 1.20.1 NeoForge please?

I do not manually support any specific version. The launcher acquires all NeoForge versions through the version list file provided by NeoForged officials. If a version is not included in this file, the launcher will be unable to obtain the corresponding version. Therefore, you should inquire with NeoForged officials regarding the whereabouts of version 1.20.1

@MovTery
Copy link
Contributor Author

MovTery commented Mar 6, 2024

can you support 1.20.1 NeoForge please?

https://maven.neoforged.net/releases/net/neoforged/neoforge/maven-metadata.xml

@zkitefly
Copy link

zkitefly commented Mar 6, 2024

@MovTery
Copy link
Contributor Author

MovTery commented Mar 6, 2024

@MovTery
Copy link
Contributor Author

MovTery commented Mar 6, 2024

你能支持 1.20.1 NeoForge 吗?

https://maven.neoforged.net/releases/net/neoforged/neoforge/maven-metadata.xml

https://maven.neoforged.net/releases/net/neoforged/forge/maven-metadata.xml

1.20.1 👆

Okay, now version 1.20.1 can be installed normally!

@Mathias-Boulay
Copy link
Contributor

Hei @HopiHopy thanks for the PR !
It is important to us that automatic installation is supported, otherwise it is as pointless as fetching the jar ourselves 😓

@Mathias-Boulay
Copy link
Contributor

Do you think you can address this ?

@MovTery
Copy link
Contributor Author

MovTery commented Mar 29, 2024

Do you think you can address this ?

I may not be able to do it because I haven't learned Java for too long and don't know how to implement automatic installation.

@zkitefly
Copy link

Tip: NeoForge for 1.20.1 is installed using the Forge installation method.

@ghost ghost mentioned this pull request Mar 30, 2024
@CADIndie
Copy link

CADIndie commented Oct 30, 2024

I believe this PR could be cleaned up a fair bit by reusing classes/methods instead of creating new, almost identical ones, specifically the ones part of the modloaders package. As for auto-installation, it should be fairly easy to do and when I have the time I will add my changes to the PR if possible as to make this PR ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants