Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3324 #3325

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix #3324 #3325

wants to merge 1 commit into from

Conversation

jbrieuclp
Copy link
Contributor

Corrige le premier point du #3324

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.97%. Comparing base (0f031f4) to head (4853d51).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3325   +/-   ##
========================================
  Coverage    83.97%   83.97%           
========================================
  Files          122      122           
  Lines         9712     9712           
========================================
  Hits          8156     8156           
  Misses        1556     1556           
Flag Coverage Δ
pytest 83.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouttier bouttier self-requested a review January 15, 2025 23:29
@bouttier
Copy link
Contributor

La colonne géométrique est utilisée à plusieurs endroits :

Pour une mise en cohérence, je pense qu’il vaut mieux utiliser du 4326, sachant que le ST_Intersect et facile à corriger en utilisant l_areas_cte.c.geom_4326 au lieu de l_areas_cte.c.geom depuis PnX-SI/RefGeo#17.

@bouttier bouttier removed their request for review January 16, 2025 10:35
@camillemonchicourt
Copy link
Member

Il n'y a pas un soucis de précision si on utilise les géométries reprojetées en 4326 pour les intersections ?

@bouttier
Copy link
Contributor

Pas si évident de dire que les géométries 4326 sont celles reprojetées, et non les géométries locales (import en 4326, sélection sur leaflet). Aucune idée de la précision inhérente aux reprojections.

@camillemonchicourt
Copy link
Member

OK, en effet.

@jacquesfize jacquesfize added this to the 2.16 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants