Governance / CIP-95 #1638
Merged
Governance / CIP-95 #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klntsky
reviewed
Jul 22, 2024
test/Ogmios/Aeson.purs
Outdated
| , aeson | ||
| } | ||
| _ -> Nothing | ||
| -- ignore empty (corrupted) fixtures |
There was a problem hiding this comment.
Are there any? Where are they from? can we get rid of them?
There was a problem hiding this comment.
Yes, there is at least one in the ogmios repository
klntsky
reviewed
Jul 22, 2024
Add parameter allowing to specify whether the CIP-95 extension should be enabled.
klntsky
reviewed
Aug 1, 2024
klntsky
reviewed
Aug 8, 2024
| @@ -172,9 +172,6 @@ | |||
| nodePackages.eslint | |||
| nodePackages.prettier | |||
| blockfrost-backend-ryo | |||
| cardano-node.packages.${system}.cardano-testnet | |||
| cardano-node.packages.${system}.cardano-cli | |||
There was a problem hiding this comment.
Because these packages are provided as part of the runtime (withRuntime flag)
klntsky
reviewed
Aug 8, 2024
- Reuse Api type from purescript-cip30 - Add cardano-testnet test suite for governance examples - Consider signers for tx certificates, withdrawals, and voting procedures when calculating min fee
klntsky
requested changes
Aug 10, 2024
klntsky
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on mlabs-haskell/cardano.nix#96mergedDepends on mlabs-haskell/purescript-cardano-hd-wallet#3
Depends on mlabs-haskell/purescript-cardano-key-wallet#3
Depends on mlabs-haskell/purescript-cardano-transaction-builder#3
Depends on mlabs-haskell/purescript-cip30-mock#2
Depends on mlabs-haskell/purescript-cip95#2
Governance examples (Ogmios + Kupo, SanchoNet, Eternl Beta & KeyWallet):
Gov.ManageDrepRegDrepCertUpdateDrepCertUnregDrepCertGov.ManageDrepScriptGov.DelegateVoteAbstainVoteRegDelegCertGov.SubmitVoteGov.SubmitVoteScriptNew CIP-95 functions exported from
Contract.Wallet:ownDrepPubKeyownDrepPubKeyHashownRegisteredPubStakeKeysownUnregisteredPubStakeKeysNOTE: KeyWallet does not distinguish between registered and unregistered stake keys due to the limitations of the underlying query layer. This means that all controlled stake keys are returned as part of
ownUnregisteredPubStakeKeys, and the response ofownRegisteredPubStakeKeysis always an empty array.Pre-review checklist
make format)templates/ctl-scaffold) has been updated## Unreleasedheader, using the appropriate sub-headings (### Added,### Changed,### Removed,### Fixed), and the links to the appropriate issues/PRs have been included