Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LITE-1151: fix aes for LG devices #30

Open
wants to merge 1 commit into
base: patch/v1.1.x
Choose a base branch
from

Conversation

JohnPaulHarold
Copy link

This PR will...

  • change the datatype of the iv arg from ArrayBuffer to Uint8Array

Why is this Pull Request needed?

  • doing this fixes using window.WebCrypto on LG devices
  • the above enabled hardware AES decryption, which matters when CPU cycles are limited

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant