Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose TimeTrace::record(timestamp, ...) in the c wrapper. #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Expose TimeTrace::record(timestamp, ...) in the c wrapper. #16

wants to merge 1 commit into from

Conversation

yilongli
Copy link
Member

#15

@yilongli yilongli force-pushed the master branch 3 times, most recently from b7804da to b6bce4a Compare November 17, 2018 04:12
@hq6 hq6 self-assigned this Apr 16, 2019
hq6
hq6 reviewed Apr 16, 2019
View reviewed changes
Copy link
Member

@hq6 hq6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yilong, please tell me in person if you make a Pull Request and I haven't responded for months. I totally just saw this because I don't seem to get email notifications on PerfUtils PR's.

cwrapper/timetrace_wrapper.h
* uint32_t arg0, uint32_t arg1, uint32_t arg2,
* uint32_t arg3);
*/
void timetrace_record_ts();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the comment in the CC file say that caller always needs to pass arg0-3 when this header clearly allows fewer arguments to be passed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hq6 hq6 hq6 left review comments

Assignees

@hq6 hq6

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yilongli @hq6