Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker setup #13

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Worker setup #13

wants to merge 8 commits into from

Conversation

ravenac95
Copy link
Collaborator

@ravenac95 ravenac95 commented Sep 4, 2020

This is a lot of prototypical work. I actually discovered that google's Cloud Firestore will actually cost us significantly less for the richer query language that comes with it as opposed to something like dynamo. Additionally, Cloud Firestore can give us the flexibility to store/query on other data in the document. All this being said, the current design is such that the storage mechanism can be replaced if necessary.

TODOS

  • Write automated tests (it's janky right now)
  • Add github action for CI
  • Test on actual google firestorm

@ravenac95
Copy link
Collaborator Author

@conorgil you can load the data into the database now using the instructions i just uploaded. Give it a try. I'll finish up the worker tomorrow with a mocked out clicksend so we can get this all merged in.

README.md Outdated Show resolved Hide resolved
docker/dev-compose.yml Outdated Show resolved Hide resolved
@conorgil
Copy link
Member

conorgil commented Sep 7, 2020

I updated the PR description to correct: firestorm -> Cloud Firestore 😉

I'm taking a look at this tonight! I'll report back.

@conorgil conorgil self-requested a review September 7, 2020 00:55
@conorgil
Copy link
Member

conorgil commented Sep 7, 2020

Request: can we create a Dockerfile to run the worker? Would make it easier than installing postgres, dealing with pipenv, etc, etc.

@ravenac95
Copy link
Collaborator Author

ravenac95 commented Sep 7, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants