Make Indices in BuildArraySubscript const again.

PetroZarytskyi · Feb 5, 2024 · ce70387 · ce70387
1 parent deddb61
commit ce70387
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/include/clad/Differentiator/VisitorBase.h b/include/clad/Differentiator/VisitorBase.h
@@ -408,7 +408,7 @@ namespace clad {
     /// a sequence of indices.
     clang::Expr*
     BuildArraySubscript(clang::Expr* Base,
-                        llvm::SmallVectorImpl<clang::Expr*>& IS);
+                        const llvm::SmallVectorImpl<clang::Expr*>& IS);
     /// Find namespace clad declaration.
     clang::NamespaceDecl* GetCladNamespace();
     /// Find declaration of clad::class templated type

diff --git a/lib/Differentiator/VisitorBase.cpp b/lib/Differentiator/VisitorBase.cpp
@@ -418,19 +418,21 @@ namespace clad {
   }
 
   Expr* VisitorBase::BuildArraySubscript(
-      Expr* Base, llvm::SmallVectorImpl<clang::Expr*>& Indices) {
+      Expr* Base, const llvm::SmallVectorImpl<clang::Expr*>& Indices) {
     Expr* result = Base;
     SourceLocation fakeLoc = utils::GetValidSLoc(m_Sema);
-    if (utils::isArrayOrPointerType(Base->getType()))
+    if (utils::isArrayOrPointerType(Base->getType())) {
       for (Expr* I : Indices)
         result =
             m_Sema.CreateBuiltinArraySubscriptExpr(result, fakeLoc, I, fakeLoc)
                 .get();
-    else
+    } else {
+      Expr* idx = Indices.back();
       result = m_Sema
-                   .ActOnArraySubscriptExpr(getCurrentScope(), Base, fakeLoc,
-                                            Indices.back(), fakeLoc)
+                   .ActOnArraySubscriptExpr(getCurrentScope(), Base, fakeLoc, idx,
+                                            fakeLoc)
                    .get();
+    }
     return result;
   }