Refactor to pass parsl_config.py and workflow_config.py as a ConfigMap #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
separate from the container image. Also run the script automatically as a Kubernetes job instead of creating a deployment where we have to start the script manually.
|
So I think the ConfigMap is a useful thing to do no matter what. wrt to having the Kubernetes job start up the script automatically, I think it's the right thing eventually, but we don't seem to have good logging right now so it might actually be easier to just keep doing the, exec into the pod and start the script manually so we can debug... I can take that part out for now if you want. |
separate from the container image. Also run the script automatically as a Kubernetes job instead of creating a deployment where we have to start the script manually.
before). I think this is still useful to keep around.
…chen/viz-workflow into enhancement-1-gks_k8s-job
|
I decided to add back the instructions for running it manually as an alternative so we have it written down how to do it either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
separate from the container image. Also run the script automatically as a Kubernetes job instead of creating a deployment where we have to start the script manually.