Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUD-875 [PS] Combine xxx-latest and an xxx-version pipelines to use common Groovy code #3109

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

ptankov
Copy link
Contributor

@ptankov ptankov commented Jan 16, 2025

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does job mean in the name? why we do not use the same naming as we have for .groovy?

Copy link
Contributor Author

@ptankov ptankov Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it makes for a better sorting in the file browser or the IDE, e.g. in VSCode. When you search for the file (Ctrl + P) and start typing pso-... you get only the groovy scripts (*.groovy). Whereas, if the pipeline definitions don't star with job... you get mixed results (both *.groovy and *.yml). It's purely for comfortable usage when you want to distinguish files.
Screenshot_2025-01-23_22-18-27
Screenshot_2025-01-23_22-18-43

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it is easier to search when the names of groovy and yml are the same (like we had, the difference was in - vs _) because it is easy to know what name of yml file to search for specific groovy file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you will probably never need to open, view or edit the job files, i.e. the *.yml files.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did ....

@ptankov ptankov requested a review from eleo007 January 23, 2025 20:20
@ptankov ptankov force-pushed the CLOUD-875-ps branch 5 times, most recently from 044351d to 31c7b71 Compare January 28, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants