-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUD-875 [PS] Combine xxx-latest and an xxx-version pipelines to use common Groovy code #3109
base: master
Are you sure you want to change the base?
Conversation
… common Groovy code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does job
mean in the name? why we do not use the same naming as we have for .groovy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it makes for a better sorting in the file browser or the IDE, e.g. in VSCode. When you search for the file (Ctrl + P) and start typing pso-...
you get only the groovy scripts (*.groovy
). Whereas, if the pipeline definitions don't star with job...
you get mixed results (both *.groovy
and *.yml
). It's purely for comfortable usage when you want to distinguish files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me it is easier to search when the names of groovy
and yml
are the same (like we had, the difference was in -
vs _
) because it is easy to know what name of yml
file to search for specific groovy
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you will probably never need to open, view or edit the job files, i.e. the *.yml
files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did ....
044351d
to
31c7b71
Compare
No description provided.