Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode extensions for GIF figures #880

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Hardcode extensions for GIF figures #880

merged 1 commit into from
Nov 18, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Nov 18, 2024

This is just until the next nireports release is made, since GIFs aren't supported yet and that's breaking the HTML report generation.

Changes proposed in this pull request

  • Hardcode extensions for figures that are actually GIFs as PNGs so they get skipped until nireports can support GIFs.

@tsalo tsalo added the bug Something isn't working label Nov 18, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.48%. Comparing base (f268f2a) to head (36d38bc).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #880   +/-   ##
=======================================
  Coverage   28.48%   28.48%           
=======================================
  Files          68       68           
  Lines       10152    10152           
  Branches     1146     1146           
=======================================
  Hits         2892     2892           
  Misses       7162     7162           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mattcieslak
Copy link
Collaborator

Will this still place the gifs in the figures directory? If so then I like this solution

@tsalo
Copy link
Member Author

tsalo commented Nov 18, 2024

The figures will still be created, but nireports won't be able to find them because it'll be looking for PNGs (which don't exist) instead. Then when the new release goes out, we can just drop the ".png" extension part and it should find the GIFs.

Copy link
Collaborator

@mattcieslak mattcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very clever workaround. Thank you!

@tsalo tsalo merged commit 606d36d into master Nov 18, 2024
20 checks passed
@tsalo tsalo deleted the ignore-gifs branch November 18, 2024 22:22
@tsalo
Copy link
Member Author

tsalo commented Nov 19, 2024

I've added an ignore-for-release label now because the changes in this PR are being reverted in #883 before the release is made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ignore-for-release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants