Replace legacy validator with schema validator #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also change cubids print-metadata-fields to account for json file errors due to not been validated yet
tsalo
reviewed
Nov 18, 2024
tsalo
reviewed
Nov 18, 2024
| command = ["bids-validator", path, "--verbose", "--json", "--ignoreSubjectConsistency"] | ||
| # New schema BIDS validator doesn't have option to ignore subject consistency. | ||
| # Build the deno command to run the BIDS validator. | ||
| command = ["deno", "run", "-A", "jsr:@bids/validator", path, "--verbose", "--json"] |
There was a problem hiding this comment.
We might want some way to provide a given version of the validator or a version of the BIDS schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #336.
Changes proposed in this pull request
cubids print-metadata-fieldsto account for json file errors due to not been validated yetDocumentation that should be reviewed