Improve Config Handling #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the way we pass configuration to initialize new loggers. It follows the same model as used in Viper. With this PR, we maintain a global logger that can be configured using the
LogInitfunction. However, there is also the flexibility of creating a new logger without modifying the global logger using theNewLoggerfunction.For most cases, applications would simply need to call
LogInitand use the global logger variable for all logging. In cases where a change in behavior is required, the application can create a new logger altogether without affecting the global logger.This PR also adds tests and introduces a GitHub workflow to run tests on push and pull requests for quick feedback.