Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server URLs in code #22

Merged
merged 5 commits into from
Apr 1, 2024
Merged

Conversation

Sweetdevil144
Copy link
Contributor

@Sweetdevil144 Sweetdevil144 commented Mar 10, 2024

Updated API server URL in code files
Fixes #21

Priority: Low
Status: Completed
Type: Bug fix

Description

Replaced all instances of 'http://localhost:8000' with 'http://pecan.localhost:80' wherever required.

Motivation and Context

This change was required to correct the API server URL in the examples provided in the example file. The incorrect URL was causing connection issues when users tried to follow the examples.

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Sweetdevil144
Copy link
Contributor Author

Used following bash command to do so :

find . -name '*.Rd' -exec sed -i '' 's|http://localhost:8000|http://pecan.localhost:80|g' {} \; && 
find . -name '*.R' -exec sed -i '' 's|http://localhost:8000|http://pecan.localhost:80|g' {} \; && 
find . -name '*.Rmd' -exec sed -i '' 's|http://localhost:8000|http://pecan.localhost:80|g' {} \;

README.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@Sweetdevil144 Sweetdevil144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the new lines were added by the linter to seperate diffferent markdown blocks

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Sweetdevil144
Copy link
Contributor Author

Any guess why the checks fail?

@mdietze
Copy link
Member

mdietze commented Mar 12, 2024

Nothing you did, just the aging of code, but there need to be some updates to the yml file. If you look at .github/workflows
/pkgdown.yml anywhere you see r-lib/actions the version needs to be updated from @master to @v2. The @master branch was renames @main but @v2 is the current recommended stable branch. See the readme at https://github.com/r-lib/actions

@Sweetdevil144
Copy link
Contributor Author

Sure. I guess it can be fixed by changing the steps as below :

- uses: actions/checkout@v2

      - uses: r-lib/actions/setup-r@v2 # Updated to use a version tag
      - uses: r-lib/actions/setup-pandoc@v2 # Updated to use a version tag

I guess the workflow control is by your side. Or should I make the changes myself?

@mdietze
Copy link
Member

mdietze commented Mar 15, 2024

@Sweetdevil144 you should make the changes yourself as part of this PR to see if that fixes the GH Action checks

As suggested by Michael : 
"the version needs to be updated from @master to @v2. The @master branch was renames @main but @v2 is the current recommended stable branch"
@Sweetdevil144
Copy link
Contributor Author

pkgdown.yml successfully runs after I opened a PR after making some linter changes : Sweetdevil144#1

Problem with ci.yml as follow : https://github.com/Sweetdevil144/rpecanapi/actions/runs/8409126911/workflow

Error : The workflow is not valid. .github/workflows/ci.yml (Line: 59, Col: 9): Unexpected value 'args'

Maybe I can replace :

- name: create account
  uses: docker://pecan/bety:latest
  args: user carya illinois "Carya Demo User" [email protected] 1 1

with

- name: create account
  uses: docker://pecan/bety:latest
  with:
    args: user carya illinois "Carya Demo User" [email protected] 1 1

Any suggestions @mdietze ?

Testing CI with linting changes
@Sweetdevil144
Copy link
Contributor Author

Hi @mdietze . Can you verify the status of this issue?

@mdietze mdietze merged commit 8c000c4 into PecanProject:master Apr 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants