-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update server URLs in code #22
Conversation
Used following bash command to do so : find . -name '*.Rd' -exec sed -i '' 's|http://localhost:8000|http://pecan.localhost:80|g' {} \; &&
find . -name '*.R' -exec sed -i '' 's|http://localhost:8000|http://pecan.localhost:80|g' {} \; &&
find . -name '*.Rmd' -exec sed -i '' 's|http://localhost:8000|http://pecan.localhost:80|g' {} \; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the new lines were added by the linter to seperate diffferent markdown blocks
Any guess why the checks fail? |
Nothing you did, just the aging of code, but there need to be some updates to the yml file. If you look at .github/workflows |
Sure. I guess it can be fixed by changing the - uses: actions/checkout@v2
- uses: r-lib/actions/setup-r@v2 # Updated to use a version tag
- uses: r-lib/actions/setup-pandoc@v2 # Updated to use a version tag I guess the workflow control is by your side. Or should I make the changes myself? |
@Sweetdevil144 you should make the changes yourself as part of this PR to see if that fixes the GH Action checks |
Problem with ci.yml as follow : https://github.com/Sweetdevil144/rpecanapi/actions/runs/8409126911/workflow Error : Maybe I can replace : - name: create account
uses: docker://pecan/bety:latest
args: user carya illinois "Carya Demo User" [email protected] 1 1 with - name: create account
uses: docker://pecan/bety:latest
with:
args: user carya illinois "Carya Demo User" [email protected] 1 1 Any suggestions @mdietze ? |
Testing CI with linting changes
Hi @mdietze . Can you verify the status of this issue? |
Updated API server URL in code files
Fixes #21
Priority: Low
Status: Completed
Type: Bug fix
Description
Replaced all instances of 'http://localhost:8000' with 'http://pecan.localhost:80' wherever required.
Motivation and Context
This change was required to correct the API server URL in the examples provided in the example file. The incorrect URL was causing connection issues when users tried to follow the examples.
Review Time Estimate
Types of changes
Checklist: