STICS' write.config using vectors of parameters to overwrite #3395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nality of SticsRFiles::set_param_xml.
istfer
approved these changes
Nov 14, 2024
| @@ -22,6 +22,7 @@ For more information about this file see also [Keep a Changelog](http://keepacha | |||
| * Modules `PEcAn.allometry`, `PEcAn.assim.batch`, `PEcAn.data.mining`, `PEcAn.emulator`, `PEcAn.MA`, `PEcAn.photosynthesis`, `PEcAn.priors`, and `PEcAn.RTM`. | |||
| - Renamed master branch to main | |||
| - `PEcAn.all::pecan_version()` now reports commit hashes as well as version numbers for each installed package. | |||
| - `write.conmfig.STICS()` now modifies parameters with vectors rather than individually. | |||
There was a problem hiding this comment.
Suggested change
| - `write.conmfig.STICS()` now modifies parameters with vectors rather than individually. | |
| - `write.config.STICS()` now modifies parameters with vectors rather than individually. |
Added which STICS file the parameter is found in to the pecan2stics lookup table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modified the usage of SticsOnR:set_param_xml() to utilise the vector functionality where many parameters can be passed to write them at once. This entailed removing the individual parameter writing calls and adding a conversion function pecan2stics() that takes pecan parameter names and converts them to the corresponding stics parameter names, along with any necessary unit conversions.
Motivation and Context
This change should speed up the use of PEcAn.STICS as there were many individual set_param_xml calls so it was slow to write configs.
Review Time Estimate
Types of changes
Checklist: