Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start new docker build #3354

Merged
merged 56 commits into from
Sep 8, 2024
Merged

start new docker build #3354

merged 56 commits into from
Sep 8, 2024

Conversation

robkooper
Copy link
Member

@robkooper robkooper commented Aug 7, 2024 •
edited
Loading

update build process

  • fixes ed

Description

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions github-actions bot added the Models label Sep 2, 2024
@robkooper robkooper mentioned this pull request Sep 3, 2024
Open
infotroph
infotroph reviewed Sep 4, 2024
View reviewed changes
docker/web/Dockerfile Show resolved Hide resolved
.github/workflows/docker.yml Outdated
Comment on lines 4 to 8
# push:
# branches:
# - main
# tags:
# - "v*.*.*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove or uncomment?

.github/workflows/docker.yml Show resolved Hide resolved
docker/base/Dockerfile Show resolved Hide resolved
models/ed/Dockerfile Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
.github/workflows/docker.yml Show resolved Hide resolved
.github/workflows/docker.yml Show resolved Hide resolved
.github/workflows/docker.yml Show resolved Hide resolved
@infotroph infotroph mentioned this pull request Sep 8, 2024
Open
@mdietze mdietze merged commit dae0f67 into develop Sep 8, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdietze mdietze mdietze left review comments

@infotroph infotroph infotroph approved these changes

Assignees
No one assigned
Labels
Dockerfile GitHub Actions Models Scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robkooper @infotroph @mdietze